Fix RNTestProject testing on Android #41378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: While releasing RN 0.73.0-RC3, we relaized that the e2e test script was bugged for Android when used to test RNTestProject with the `-c` option. There were 2 problems: - The downloaded maven-local was not actually used because it doesn't work with a zip. (We were always downloading a version from Maven) - The versions of React Native between maven-local and the locally packaged React Native were different. This change fixes the script by: - Downloading maven-local - Unzipping maven-local and passing the new folder to the Android app - Downloading the React Native version that has been packaged in CI By unzipping maven-local and using the unzipped folder, we make sure that Android is actually using the local repository. By downloading both the packaged react native and the maven-local from the same CI workflow, we ensure that the versions are aligned. This also speeds-up further the Android testing. While running this change, we also moved the `pod install` step inside the `if (iOS)` branch, so we do not install Cocoapods if we need to test Android. [Internal] - Fix Android E2E test script when downloading artefacts from CI Pull Request resolved: #41172 Test Plan: Tested locally on both main and 0.73-stable, on both Android and iOS Reviewed By: cortinico Differential Revision: D50651448 Pulled By: cipolleschi fbshipit-source-id: 70a9ed19072119d19c5388e8a4309d7333a08e13
facebook-github-bot
added
CLA Signed
cipolleschi
requested changes
Nov 8, 2023
There was a problem hiding this comment.
You also need d09c02f on top of these changes, which looks good to me.
Summary: Last week, I modified the e2e script to make sure it was working properly with 0.73. This change backport those changes in main ## Changelog: [Internal] - Backport e2e script changes Pull Request resolved: #41332 Test Plan: Tested locally Reviewed By: dmytrorykun Differential Revision: D51025796 Pulled By: cipolleschi fbshipit-source-id: 89ecd3701eaac4ba4bdde2c640df45a158329158
Base commit: 1bcd286 |
cipolleschi
reviewed
Nov 8, 2023
This was referenced Jan 4, 2024
This was referenced Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Cherry pick of 4eed12b. Doing a PR due to merge conflicts.
Changelog:
[Internal] - Fix Android E2E test script when downloading artefacts from CI
Test Plan:
See test plan in #41172